Add toggle for time-sensitive tests. #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Sometimes, like when running under TSan, it's useful to disable long running tests, or those which are sensitive to time. Modifications: Add an option to disable time sensitive tests via an envrionment variable. Result: Certain tests are skipped if `ENABLE_TIMING_TESTS` is set to false.
|
Fixes #621 |
|
Fixes #437 |
MrMage
reviewed
Dec 19, 2019
Tests/GRPCTests/GRPCTestCase.swift
Outdated
| @@ -24,7 +24,26 @@ class GRPCTestCase: XCTestCase { | |||
| // locally; conditionally enable it based on the environment. | |||
| // | |||
| // https://docs.travis-ci.com/user/environment-variables/#default-environment-variables | |||
| private static var isLoggingEnabled = ProcessInfo.processInfo.environment["CI"] != "true" | |||
| private static let isLoggingEnabled = !Bool( | |||
There was a problem hiding this comment.
!Bool looks a bit ugly — can we avoid that?
| var runTimeSensitiveTests: Bool { | ||
| let shouldRun = GRPCTestCase.runTimeSensitiveTests | ||
| if !shouldRun { | ||
| print("Skipping '\(self.name)' as ENABLE_TIMING_TESTS=false") |
There was a problem hiding this comment.
This side effect feels like a code small; at least convert this into a func? Also, what will self.name evaluate to?
There was a problem hiding this comment.
Sure, let's make it a func. I'm okay with the side effect as it's only a print message in tests.
self.name looks like "-[FunctionalTestsMutualAuthentication testUnaryLotsOfRequests]"
MrMage
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes, like when running under TSan, it's useful to disable long
running tests, or those which are sensitive to time.
Modifications:
Add an option to disable time sensitive tests via an envrionment
variable.
Result:
Certain tests are skipped if
ENABLE_TIMING_TESTSis set to false.